Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix todo & corner case for scaling in sql backend #14935

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: fix todo & corner case for scaling in sql backend #14935

merged 2 commits into from
Feb 2, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Feb 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@shanicky shanicky requested a review from yezizp2012 February 1, 2024 13:56
@github-actions github-actions bot added the type/fix Bug fix label Feb 1, 2024
yezizp2012
yezizp2012 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shanicky shanicky enabled auto-merge February 1, 2024 14:00
@shanicky shanicky added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2024
@yezizp2012 yezizp2012 added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 14a2534 Feb 2, 2024
26 of 27 checks passed
@yezizp2012 yezizp2012 deleted the peng/fix-sql-autoscale branch February 2, 2024 01:40
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@shanicky @yezizp2012
fix: fix todo & corner case for scaling in sql backend (#14935)
bc5e448 
Co-authored-by: August <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
yezizp2012 added a commit that referenced this pull request Feb 2, 2024
@github-actions @shanicky @yezizp2012
fix: fix todo & corner case for scaling in sql backend (#14935) (#14940)
3c4b64d 
Co-authored-by: Shanicky Chen <[email protected]>
Co-authored-by: August <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanicky @yezizp2012